On 10/22/2010 08:17 AM, Luiz Capitulino wrote:
You and Gerd asked about the purpose of this command, turns out that it's
only useful for developing new USB devices for QEMU, so I thought it would
be better to restrict it, so that people don't start using this the
wrong way or worse, we can't drop/break it because some tool is now using it.
Need HMP commands have no support associated with them. Given QMP,
there's no reason to script HMP commands.
But a long standing policy in QEMU has been to avoid conditional code
because it results in dead code. I think this policy has actually
worked well for us historically.
Regards,
Anthony Liguori
Anyway, maybe a good doc will do, this was just a small suggestion.
Objections, Anthony?
Not with better docs.
Regards,
Anthony Liguori
This is just adding a HMP command. Is that the right approach or
was that an unintentional consequence of rebasing post-HMP/QMP
split?
I don't think this should be available under QMP, it's more a debugging
command for USB developers.
Regards,
Anthony Liguori
cheers,
Gerd
