* Kevin Wolf <kw...@redhat.com> [2010-10-22 11:12]: > Am 22.10.2010 17:48, schrieb Luiz Capitulino: > > On Thu, 21 Oct 2010 21:55:51 -0500 > > Ryan Harper <ry...@us.ibm.com> wrote: > > > >> This patch series decouples the detachment of a block device from the > >> removal > >> of the backing pci-device. Removal of a hotplugged pci device requires the > >> guest to respond before qemu tears down the block device. In some cases, > >> the > >> guest may not respond leaving the guest with continued access to the block > >> device. > >> > >> The new monitor command, drive_unplug, will revoke a guests access to the > >> block device independently of the removal of the pci device. > >> > >> The first patch adds a new drive find method, the second patch implements > >> the > >> monitor command and block layer changes. > > > > Reviewed the monitor part, I think we're waiting for Kevin's and/or > > Markus's ACK to get this merged? > > Yes, I'm waiting for Markus' comments before applying this. > > Maybe we shouldn't add this to QMP yet, drive_add doesn't exist there > either because we want to do it right with blockdev_add/del. On the > other hand Markus should know much better than me what the right thing > would look like - if he says that this interface will work with whatever > we're going to get with blockdev_*, I'm fine with merging it.
I can go either way. Anthony asked me to re-spin with a QMP version; but the libvirt patch works either via TextMonitor or JSONMonitor. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com
