On Fri, Oct 22, 2010 at 3:22 PM, Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> wrote: > On Thu, Oct 21, 2010 at 08:13:51PM +0000, Blue Swirl wrote: >> Replace debug printf statements with tracepoints. >> >> Signed-off-by: Blue Swirl <blauwir...@gmail.com> >> --- >> There were problems with tracetool if the tracepoint string contained >> parentheses or brackets, so I removed those. >> >> hw/cs4231.c | 20 ++------- >> hw/eccmemctl.c | 46 +++++++++------------- >> hw/lance.c | 14 ++----- >> hw/slavio_intctl.c | 38 ++++++------------ >> hw/slavio_misc.c | 51 ++++++++++--------------- >> hw/slavio_timer.c | 49 ++++++++--------------- >> hw/sparc32_dma.c | 42 ++++++-------------- >> hw/sun4m.c | 18 ++------ >> hw/sun4m_iommu.c | 33 ++++----------- >> trace-events | 108 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 10 files changed, 213 insertions(+), 206 deletions(-) > > Acked-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com>
Thanks. > Out of interest, why is %8.8x used instead of %08x? Is there a > difference in meaning or just style? Both seems to produce the same results. %08x is a bit shorter, so that should be preferred.