On 25/04/17 15:57, Peter Maydell wrote: > On 21 April 2017 at 09:28, Mark Cave-Ayland > <mark.cave-ayl...@ilande.co.uk> wrote: >> This was an artifact from very early versions of the code from before the >> memory API and is no longer needed. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> Reviewed-by: Gerd Hoffmann <kra...@redhat.com> >> --- >> hw/display/cg3.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/hw/display/cg3.c b/hw/display/cg3.c >> index 1174220..7d43694 100644 >> --- a/hw/display/cg3.c >> +++ b/hw/display/cg3.c >> @@ -26,7 +26,6 @@ >> #include "qemu/osdep.h" >> #include "qapi/error.h" >> #include "qemu-common.h" >> -#include "cpu.h" >> #include "qemu/error-report.h" >> #include "ui/console.h" >> #include "hw/sysbus.h" >> @@ -114,7 +113,7 @@ static void cg3_update_display(void *opaque) >> for (y = 0; y < height; y++) { >> int update = s->full_update; >> >> - page = (y * width) & TARGET_PAGE_MASK; >> + page = y * width; > > Coverity warns that this is multiplying two 32 bit quantities > and giving a 32 bit result that's then assigned to a 64 bit variable. > Casting like: > page = (ram_addr_t)y * width; > > is the usual way to placate it.
Ah okay. I've done a quick test here and the above change seems fine so I'll send along a patch. ATB, Mark.