On 09/05/17 19:14, Peter Xu wrote: >> +void memory_region_init_iommu(IOMMUMemoryRegion *iommu_mr, >> + Object *owner, >> + const MemoryRegionIOMMUOps *ops, >> + const char *name, >> + uint64_t size) >> +{ >> + memory_region_init_iommu_type(TYPE_IOMMU_MEMORY_REGION, iommu_mr, >> + owner, ops, name, size); > > I see that memory_region_init_iommu_type() is only used to create > TYPE_IOMMU_MEMORY_REGION typed MRs. Then would > memory_region_init_iommu() enough for us? Or do you have plan to add > new memory region types?
Yes, I am still thinking of adding TYPE_SPAPR_TCE_IOMMU_MEMORY_REGION later, for strict types checking when enabling in-kernel DMA operations support (our SPAPR thingy). -- Alexey