Hi Philippe, On 09.05.2017 18:49, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 05/09/2017 02:19 AM, Thomas Huth wrote: >> On 09.05.2017 01:39, Philippe Mathieu-Daudé wrote: >>> This field is accessed in hw/intc/arm_gicv[23*].c >> >> default-configs/arm-softmmu.mak sets CONFIG_PCI, so this should not be >> necessary, I think. Otherwise, you should extend your patch description, >> to elaborate on what you're trying to do here. >> >> Thomas > > Sure, I'm willing to add basic support for the TI Hercules MCU which is > a big endian SoC (without PCI support). > > I'm using the following config: > > $ cat default-configs/armeb-softmmu.mak
$ cat default-configs/armeb-softmmu.mak cat: default-configs/armeb-softmmu.mak: No such file or directory ... so you're planning for a new armeb config file here? That's the kind of information that I was missing in the patch description. [...] > As I understand the 'msi_nonbroken' is a kludge (there is no intrinsic > relationship between PCI/MSI and this particular interrupt controller). > Since it is declared as extern in "hw/pci/msi.h" why not define it in > pci-stub? Sure, your patch is fine, IMHO it just lacks some rationale in its description. Thomas
