On 10/05/2017 19:26, Max Reitz wrote: >> + if (curl_init_state(s, state) < 0) { >> + curl_clean_state(state); > > We could also initialize state to NULL and call curl_clean_state() under > out: if state != NULL. Then again, it would only save us two > curl_clean_state() instances... > > So I'll leave it to you and unconditionally give a > > Reviewed-by: Max Reitz <mre...@redhat.com>
Makes sense, but OTOH you could also move locking to curl_co_preadv and get rid of "out" altogether. So for now I left curl_clean_state here. Paolo