On Thu, May 11, 2017 at 10:46:01AM +0200, Laurent Vivier wrote: > On 11/05/2017 02:41, David Gibson wrote: > > On Wed, May 10, 2017 at 05:05:34PM -0300, Philippe Mathieu-Daudé wrote: > >> Applied using Coccinelle script. > >> > >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > > David, look at Nikunj's comments: only the two first changes are correct. > > 'andi" uses a mask, but extract uses a 'width'. Philippe's changes work > only when mask = 1.
Oops, that was sloppy of me, sorry.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
