Eric Blake <ebl...@redhat.com> wrote: > On 05/11/2017 11:32 AM, Juan Quintela wrote: >> Those two capabilities were added through the command line. Notice that >> we just created them. This is just the boilerplate. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> >> -- >> >> Make migrate_set_block_* take a boolean argument. > > Question - do we support the orthogonal selection of all 4 combinations > under HMP 'migrate' (no argument, -b alone, -i alone, -b and -i > together), or are there only 3 actual states? If the latter, should we > represent this as a single enum-valued property, rather than as two > independent boolean properties?
{ 'enum': 'MigrationCapability', 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks', 'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram'] } My understanding is that we can only have boolean capabilities here. Or, how could we put a non-boolean capability? There are three states as far as I can see. Later, Juan.