On Mon, May 15, 2017 at 03:16:02PM +0200, Greg Kurz wrote: > On Mon, 15 May 2017 14:22:32 +0200 > Cédric Le Goater <c...@kaod.org> wrote: > > > On 05/15/2017 01:40 PM, Greg Kurz wrote: [snip] > > > + > > > + object_initialize(obj, sizeof(ICPState), spapr->icp_type); > > > + object_property_add_child(OBJECT(spapr), "icp[*]", obj, > > > + &error_abort); > > > > David does not like the "icp[*]" syntax. > > > > Ah... I wasn't aware of that. But I agree that I should probably create > the object names based on 'i', rather than relying on the more complex > logic in object_property_add().
Right, the non-obviousness of what the indicies will end up being is exactly why I dislike the "[*]" syntax. Especially here, where it's clearly important that the QOM paths end up exactly like in older qemu versions, I think it's better to be explicit. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature