On Thu, 18 May 2017 15:58:31 +0200 Greg Kurz <gr...@kaod.org> wrote: > If we go that far on the path of hot-removing a core and we find out that > the core-id is invalid, then we have a serious bug. > > Let's make it explicit with an assert() instead of dereferencing a NULL > pointer. > > This fixes Coverity issue CID 1375404. > > Signed-off-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Igor Mammedov <imamm...@redhat.com>
> --- > hw/ppc/spapr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 0980d733cd7a..1c5b814fc0bf 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2715,6 +2715,7 @@ static void spapr_core_unplug(HotplugHandler > *hotplug_dev, DeviceState *dev, > CPUCore *cc = CPU_CORE(dev); > CPUArchId *core_slot = spapr_find_cpu_slot(ms, cc->core_id, NULL); > > + assert(core_slot); > core_slot->cpu = NULL; > object_unparent(OBJECT(dev)); > } > >
