* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/18/2017 07:47 PM, Dr. David Alan Gilbert wrote: > >> Hi! > >> > >> I also wonder what is the best way to do this with vmstate. I know there > >> are VMSTATE_*_EQUAL macros for integers, and I have partially modelled my > >> patch after that, but there we only get a != b as error message, which is > >> satisfactory for detecting bugs which are supposed to get fixed. In this > >> particular case having a verbose error message should be really helpful > >> and thus important. > >> > >> I'm asking because I'm currently working on a vmstate conversion of the > >> s390x css and virtio-ccw stuff (find my latest patch set here > >> https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01364.html). > > I think the way to solve that problem will probably be adding a 'hint' > > parameter to the VMSTATE_*_EQUAL macros that is a constant string, > > stuff a pointer to that into a possibly new field in VMStateField, > > and then make the get_*_equal functions include that string in the > > message like you do. There's a lot of copy and paste but it's > > not too bad now that Jianjun's patch from a few months ago passed > > the VMStateField* to the .get/.put. > > > > Dave > > > > > > Thanks Dave! I read your reply like you are seeing this verbose > message if VMSTATE_*_EQUAL feature something worth of inclusion. > Am I right?
Yes. > If yes, I'm willing to implement it. Please do! Dave > Halil > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
