On Tue, May 09, 2017 at 02:27:35PM +0100, Daniel P. Berrange wrote: > Change the nested if statements into a flat format, to make > it clearer what validation / capping is being performed on > different CPUID index values. > > NB this changes behaviour when "index > env->cpuid_xlevel2". > This won't have any guest-visible effect because no there is > no CPUID[0xC0000001]
Nit: When applying, maybe the maintainer could fix the typo: "because no there is no" -> "because there is no" > feature supported by TCG, and KVM code > will never call cpu_x86_cpuid() with such an index value. > > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > target/i386/cpu.c | 35 +++++++++++++++-------------------- > 1 file changed, 15 insertions(+), 20 deletions(-) > [...] -- /kashyap
