Am 23.05.2017 um 17:46 hat Eric Blake geschrieben: > On 05/23/2017 09:01 AM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > --- > > tests/qemu-iotests/183 | 121 > > +++++++++++++++++++++++++++++++++++++++++++++ > > tests/qemu-iotests/183.out | 48 ++++++++++++++++++ > > tests/qemu-iotests/group | 1 + > > 3 files changed, 170 insertions(+) > > create mode 100755 tests/qemu-iotests/183 > > create mode 100644 tests/qemu-iotests/183.out > > Does this test gracefully skip when coupled with the efforts for a > configure option to disable block migration? > https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg04398.html
Obviously it doesn't. How would we even check? Just grep whether the magic error string turns up somewhere after doing 'migrate -b'? I don't think we have other test cases that don't skip immediately, but only after doing half of the test, but I think it might work anyway. > > +echo > > +echo === Do block migration to destination === > > +echo > > + > > +_send_qemu_cmd $src "migrate -b unix:${MIG_SOCKET}" "(qemu)" > > I don't see any earlier checks, so it looks like you'd choke here if -b > is not compiled in. > > Should we also check the use of -i? Good point, though I don't even know how to use -i manually. :-) We can either have a follow-up patch extending this one or a completely separate test case for it. I would have to try out -i before I could say which makes more sense. Kevin
pgpIbuEY8Irv7.pgp
Description: PGP signature