On Thu, May 25, 2017 at 05:57:43PM +0200, Maxime Coquelin wrote:
>
>
> On 05/24/2017 11:58 PM, Michael S. Tsirkin wrote:
> > On Wed, May 24, 2017 at 11:05:20AM +0200, Maxime Coquelin wrote:
> > > process_message_reply() was recently updated to get full message
> > > content instead of only its request field.
> > >
> > > There is no need to copy all the struct content into the stack,
> > > so just pass its pointer as const.
> > >
> > > Cc: Zhiyong Yang <zhiyong.y...@intel.com>
> > > Fixes: 60cd11024f41 ("hw/virtio: fix vhost user fails to startup when MQ")
> > > Reviewed-by: Jens Freimann <jfrei...@redhat.com>
> > > Reviewed-by: Zhiyong Yang <zhiyong.y...@intel.com>
> > > Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
> >
> > Why "Fixes"? It's not a bugfix, is it? Passing a pointer is
> > slightly cleaner but it's not a big deal IMHO. I'll apply
> > but would like to get clarification on this tag.
>
> Right, this is not a bug fix.
> I noticed this while rebasing my Vhost-user IOMMU series,
> which will call this function much more often than currently.
> That said, I haven't done any measurements, and I don't believe it
> will have a noticeable impact.
>
> Feel free to remove the "Fixes:" line when applying, or I can resend
> if you prefer.
>
> Maxime
Applied no need to resend.
