Re: [Qemu-devel] [PATCH 21/26] target/s390x: implement PACK UNICODE

[Richard Henderson]

On 05/25/2017 02:05 PM, Aurelien Jarno wrote:
+        } else if (srclen > ssize) {
              b = cpu_ldub_data_ra(env, src, ra) & 0x0f;
-            src--;
-            srclen--;
+            src -= ssize;
+            srclen -= ssize;

Surely we need to use lduw in order to correctly read the big-endian 16-bit 
value, or bias src by +1 to read the low byte of same.


r~