On Tue, May 30, 2017 at 06:08:04PM +0100, Peter Maydell wrote: > On 30 May 2017 at 15:01, Eduardo Habkost <ehabk...@redhat.com> wrote: > > On Tue, May 30, 2017 at 11:45:55AM +0100, Peter Maydell wrote: > >> Hi all; I'm afraid this patch breaks compilation on OSX: > > > > It looks like this wasn't detected by travis-ci because the build > > is not using -Werror: > > https://travis-ci.org/ehabkost/qemu/jobs/236485778#L3881 > > Hmm. It would be nice to fix that. configure doesn't enable -Werror > by default on OSX because it doesn't handle some of the pragmas > to disable warnings that we use, but on the typical OSX build > the warnings that we use the pragmas to suppress don't get > generated anyway, so -Werror works in practice. It needs > configure '--extra-cflags=-Werror' to turn on. > (It might also need --disable-vnc-sasl depending on OSX version > since Apple helpfully added a pile of deprecation warnings to > their version of the sasl headers without suggesting what to > use instead.)
The same warnings hit libvirt on OS-X too and some pragmas were sufficient to shut it up _Pragma ("GCC diagnostic push") _Pragma ("GCC diagnostic ignored \"-Wdeprecated-declarations\"") .... sasl code... _Pragma ("GCC diagnostic pop") Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|