On Tue, May 30, 2017 at 03:27:33PM +0100, Peter Maydell wrote: > On 25 May 2017 at 20:10, Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> > wrote: > > Essentialy the code for PowerPC BE and LE are the same, so this patch > > renames all *ppc64le.* files to *ppc64.* and reflects such in the > > Makefile. > > > > Due to the fact that all supported archs are covered by guess_arch > > function, this also drops the ARCH parameter from the Makefile. > > This change isn't right -- the point is that guess_arch might > (in theory) guess wrong, so the user can override it. > > You forgot to delete the comment about "powerpc64-linux-gnu doesn't > work" from the build-all-archs script. > > The rest is fine though, so I've made those minor tweaks and > applied the series to risu master. > > PS: for patches like this there is a neat git option --find-renames > which you can use when you're generating the patch email to > create smaller and easier to read patches. > > thanks > -- PMM >
Peter, thanks for your review, I always learn from it. Just added the "git config diff.renames true; git config diff.algorithm patience" config here. Next time it'll be better indeed! :) Thanks
