Hi, Markus
On 05/29/2017 03:51 PM, Markus Armbruster wrote:
Igor Mammedov <imamm...@redhat.com> writes:
On Fri, 26 May 2017 16:29:25 +0800
Mao Zhongyi <maozy.f...@cn.fujitsu.com> wrote:
ioh3420_interrupts_init() and its callers, rp_realize() and
pci_qdev_realize() fill error message to local_err, then
propagate it to errp by error_porpagate(), which's not necessary.
So eliminate it and pass errp directly instead of local_err.
Of course, error_propagate() also will be removed.
Signed-off-by: Mao Zhongyi <maozy.f...@cn.fujitsu.com>
---
[...]
dropping local_error here looks wrong since it's used
to check error status inside these functions and to undo
side effects in case of failure.
consider if caller pass errp = NULL
then error handling path won't be executed.
Exactly. The big comment in include/qapi/error.h explains this and
more.
Thanks for providing the specific path, I have seen detailed comments
that have really helped me.
Thanks,
Mao
So keep the rest of the patch but drop above hunks.
