On Wed, May 31, 2017 at 12:39:25PM +0100, Dr. David Alan Gilbert wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
> > Everything else assumes that we always load a device from its own
> > savevm handler.
>
> Except for the title (it's the version_id you're removing not
> section_id) but now I think this series is ok because you're always
> using
> the load_* stuff.
>
> I guess in manyways the LoadStateEntry list made some sense; it was
> harder to accidentally use version_id rather than load_version_id if
> it was on a different pointer.
Indeed. After all it was:
struct LoadStateEntry {
QLIST_ENTRY(LoadStateEntry) entry;
SaveStateEntry *se;
int section_id;
int version_id;
};
And we moved the two variables into SaveStateEntry.
(I admit I didn't really notice the difference in v1...)
>
> But generally now for the series:
>
> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
>
>
> Dave
>
> > Signed-off-by: Juan Quintela <quint...@redhat.com>
> > Reviewed-by: Laurent Vivier <lviv...@redhat.com>
> > Reviewed-by: Peter Xu <pet...@redhat.com>
Thanks,
--
Peter Xu
