On Wed, May 31, 2017 at 06:15:27PM +0200, Max Reitz wrote: > On 2017-05-09 19:33, Daniel P. Berrange wrote: > > On some distros, whenever you close a block device file > > descriptor there is a udev rule that resets the file > > permissions. This can race with the test script when > > we run qemu-io multiple times against the same block > > device. Occasionally the second qemu-io invocation > > will find udev has reset the permissions causing failure. > > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > tests/qemu-iotests/149 | 13 +- > > tests/qemu-iotests/149.out | 344 > > ++++++++++++++++++++++----------------------- > > 2 files changed, 178 insertions(+), 179 deletions(-) > > > > diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149 > > index 5faf585..bc628ce 100755 > > --- a/tests/qemu-iotests/149 > > +++ b/tests/qemu-iotests/149 > > @@ -23,6 +23,7 @@ > > import subprocess > > import os > > import os.path > > +import time > > Why?
That's left over cruft from debugging this test. I'll kill it. > Rest looks good. Does that count for "reviewed-by" if i kill the import ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
