* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Just for the functions exported from tls.c. Notice that we can't > >> remove the migration/migration.h include from tls.c because it access > >> directly MigrationState for the tls params. > > >> +++ b/migration/tls.h > >> @@ -0,0 +1,34 @@ > >> +/* > >> + * QEMU migration TLS support > >> + * > >> + * Copyright (c) 2015 Red Hat, Inc. > >> + * > >> + * This library is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2 of the License, or (at your option) any later version. > >> + * > >> + * This library is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with this library; if not, see > >> <http://www.gnu.org/licenses/>. > >> + * > >> + */ > > > > Can you clarify why this is LGPLv2 or later please? > > Is this to follow the io/* rather than the migration/migration.h it came > > out of. > > THis is the license of tls.c > > And this are only the two functions that are exported from that file, so > .... > > And anyways, this code is posterior to the cut-off when everything new > is GPL2 or later. > > Or I am missing something?
No, that's fair, I was following migration.h rather than the .c, but that's OK. Dave > Later, Juan. > > > > > > Anyway, I did see Dan's post saying it was OK to update licenses, but > > it's worth a comment in the commit message as to why. > > > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > > > > > Dave > > > >> + > >> +#ifndef QEMU_MIGRATION_TLS_H > >> +#define QEMU_MIGRATION_TLS_H > >> + > >> +#include "io/channel.h" > >> + > >> +void migration_tls_channel_process_incoming(MigrationState *s, > >> + QIOChannel *ioc, > >> + Error **errp); > >> + > >> +void migration_tls_channel_connect(MigrationState *s, > >> + QIOChannel *ioc, > >> + const char *hostname, > >> + Error **errp); > >> +#endif > >> -- > >> 2.9.4 > >> > > -- > > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK