On Mon, Jun 05, 2017 at 06:01:38PM +0100, Peter Maydell wrote: > In qemu_gluster_parse_json(), the call to qdict_array_entries() > could return a negative error code, which we were ignoring > because we assigned the result to an unsigned variable. > Fix this by using the 'int' type instead, which matches the > return type of qdict_array_entries() and also the type > we use for the loop enumeration variable 'i'. > > (Spotted by Coverity, CID 1360960.) > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > block/gluster.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/gluster.c b/block/gluster.c > index 031596a..addceed 100644 > --- a/block/gluster.c > +++ b/block/gluster.c > @@ -493,8 +493,7 @@ static int qemu_gluster_parse_json(BlockdevOptionsGluster > *gconf, > Error *local_err = NULL; > char *str = NULL; > const char *ptr; > - size_t num_servers; > - int i, type; > + int i, type, num_servers; > > /* create opts info from runtime_json_opts list */ > opts = qemu_opts_create(&runtime_json_opts, NULL, 0, &error_abort); > -- > 2.7.4 >
Thanks, Reviewed-by: Jeff Cody <jc...@redhat.com> Also - applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc block -Jeff
