On 6 June 2017 at 16:41, Greg Kurz <gr...@kaod.org> wrote:
> On Tue, 6 Jun 2017 16:28:26 +0100
> Peter Maydell <peter.mayd...@linaro.org> wrote:
>
>> On 6 June 2017 at 16:22, Greg Kurz <gr...@kaod.org> wrote:
>> > The string returned by object_property_get_str() is dynamically allocated.
>> >
>> > Signed-off-by: Greg Kurz <gr...@kaod.org>
>> > ---
>> > target/ppc/kvm.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
>> > index 88817620766c..f2f7c531bc7b 100644
>> > --- a/target/ppc/kvm.c
>> > +++ b/target/ppc/kvm.c
>> > @@ -486,6 +486,7 @@ bool kvmppc_is_mem_backend_page_size_ok(const char
>> > *obj_path)
>> >
>> > if (mempath) {
>> > pagesize = qemu_mempath_getpagesize(mempath);
>> > + g_free(mempath);
>> > } else {
>> > pagesize = getpagesize();
>> > }
>>
>> Huh, I wasn't expecting this function to free its argument.
>
> Hmm... mempath isn't an argument, it is computed locally:
Oops; sorry, I misread the patch.
thanks
-- PMM
