On 06/07/2017 06:35 PM, Juan Quintela wrote: > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: >> Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL >> so the hint states the assertion probably failed due to a bug. Introduce >> _EQUAL_HINT for specifying a context specific hint. >> >> Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> >> --- >> Keeping this separate for now because we may want something different >> here. E.g. no new macros and adding an extra NULL parameter for all >> pre-existing _EQUAL usages. > > > I think that the best thing is to just add the HINT always. I checked > and there are only 25 uses of VMSTATE_*_EQUAL. I agree with dave that > adding a NULL there, and make they work is a better strategy. >
Will do that! > We are adding 8 new macros so we don't have to change 25 callers? > It was more the fear of needlessly complicating the interface that made me do this version first (I assumed typical usage is without hint with the purpose of catching bugs). I also wanted to avoid bothering a lot's of people in the first round (I assume the usages are spread over files owned by various maintainers). Thanks for your review! Regards, Halil