On Wed, Jun 07, 2017 at 07:47:04PM +0200, Cédric Le Goater wrote: 1;4602;0c> On 06/07/2017 07:17 PM, Greg Kurz wrote: > > Taking into account that qemu_set_irq() returns immediatly if its first > > argument is NULL, icp_kvm_reset() largely duplicates icp_reset(). > > > > This patch introduces a reset() handler, so that the common logic can > > be implemented in icp_reset() only. > > > > While there we can also drop icp_kvm_realize() and icp_kvm_unrealize(). This > > causes icp-kvm to be realized in icp_realize(), which sets icp->xics, but > > it has no impact. > > > > Signed-off-by: Greg Kurz <gr...@kaod.org> > > > Reviewed-by: Cédric Le Goater <c...@kaod.org> > > > --- > > hw/intc/xics.c | 5 +++++ > > hw/intc/xics_kvm.c | 27 ++------------------------- > > include/hw/ppc/xics.h | 1 + > > 3 files changed, 8 insertions(+), 25 deletions(-) > > another good cleanup !
I concur. Applied to ppc-for-2.10. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature