On Fri, Jun 09, 2017 at 07:24:40PM +0800, Mao Zhongyi wrote: > After the patch 'Make errp the last parameter of pci_add_capability()', > pci_add_capability() and pci_add_capability2() now do exactly the same. > So drop the wrapper pci_add_capability() of pci_add_capability2(), then > replace the pci_add_capability() with pci_add_capability2() everywhere.
I would do the opposite, and keep pci_add_capability() only. It's confusing to have a function named pci_add_capability2() if pci_add_capability() doesn't exist anymore. -- Eduardo
