On 06/09/2017 10:55 AM, Kevin Wolf wrote: >> >> These belong in comments in the test proper, because it is not obvious >> otherwise. But with comments added (so someone debugging a theoretical >> test failure down the road knows what they are up against), > > # Note that the reference output intentionally includes the 'offset' field in > # BLOCK_JOB_CANCELLED events for all of the following block jobs. They are > # predictable and any change in the offsets would hint at a bug in the job > # throttling code. > # > # In order to achieve these predictable offsets, all of the following tests > # use speed=65536. Each job will perform exactly one iteration before it has > # to sleep at least for a second, which is plenty of time for the 'quit' QMP > # command to be received (after receiving the command, the rest runs > # synchronously, so jobs can arbitrarily continue or complete). > # > # The buffer size for commit and streaming is 512k (waiting for 8 seconds > after > # the first request), for active commit and mirror it's large enough to cover > # the full 4M, and for backup it's the qcow2 cluster size, which we know is > # 64k. As all of these are at least as large as the speed, we are sure that > the > # offset doesn't advance after the first iteration before qemu exits. > > Does this look okay?
Yes, that looks fine. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
