On Fri, Jun 09, 2017 at 12:58:17 -0700, Richard Henderson wrote: > >>=== OUTPUT BEGIN === > >>Checking PATCH 1/7: util: add cacheinfo... > >>ERROR: do not initialise globals to 0 or NULL > >>#149: FILE: util/cacheinfo.c:11: > >>+int qemu_icache_linesize = 0; > >> > >>ERROR: do not initialise globals to 0 or NULL > >>#150: FILE: util/cacheinfo.c:12: > >>+int qemu_dcache_linesize = 0; > > These are bogus checkpatch warnings. If we really want this, we should also > use -fno-common. But without that, there is a real difference between > initialized and non-initialized global variables. > > >> > >>ERROR: space prohibited after that '&&' (ctx:ExW) > >>#191: FILE: util/cacheinfo.c:53: > >>+ && buf[i].Cache.Level == 1) { > >> ^ > > This is also bogus. I have no idea what it's attempting to detect.
I think this one is just enforcing a certain coding style convention; "A &&\nB" will pass but "A\n&&B" won't. E.