On 14/06/2017 19:02, Felipe Franciosi wrote: > >> On 14 Jun 2017, at 17:59, no-re...@patchew.org wrote: >> >> Hi, >> >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce >> it >> locally. >> >> Message-id: 1497458486-15673-1-git-send-email-fel...@nutanix.com >> Type: series >> Subject: [Qemu-devel] [PATCH] vhost-user: support cross-endianess negatiation >> > ... >> >> CC hw/pci-bridge/pci_expander_bridge.o >> In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: >> /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of >> typedef ‘LoadStateHandler’ >> /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous >> declaration of ‘LoadStateHandler’ was here >> make: *** [hw/net/vmxnet3.o] Error 1 >> make: *** Waiting for unfinished jobs.... >> tests/docker/Makefile.include:118: recipe for target 'docker-run' failed >> make[1]: *** [docker-run] Error 2 >> make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-enl3ixyr/src' >> tests/docker/Makefile.include:149: recipe for target >> 'docker-run-test-build@min-glib' failed >> make: *** [docker-run-test-build@min-glib] Error 2 >> === OUTPUT END === >> >> Test command exited with code: 2 > > That seems completely unrelated to what our patch touched... I'm gonna guess > this is a known issue and I can safely ignore it?
Yes. Juan, can you take a look? Just removing the typedef from VMStateDescription, and instead just using int(*load_state_old)(etc...) should do it. Paolo