On 06/14/2017 10:49 AM, Alex Bennée wrote:
I think this is a band-aid, and would rather fix the front-ends as in Emilio's patch.It seems a shame to cause all msr accesses to trigger and exit when we only care about the unmasking case. How about: Author: Alex Bennée <alex.ben...@linaro.org> Date: Wed Jun 14 18:46:01 2017 +0100 target/arm/op_helper: ensure we exit the run-loop When IRQs are un-masked we need to ensure the run-loop is exited so we can evaluate arm_cpu_do_interrupt. Signed-off-by: Alex Bennée <alex.ben...@linaro.org> diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index 2a85666579..7e67bb3db2 100644 --- a/target/arm/op_helper.c +++ b/target/arm/op_helper.c @@ -835,6 +835,9 @@ void HELPER(msr_i_pstate)(CPUARMState *env, uint32_t op, uint32_t imm) break; case 0x1f: /* DAIFClear */ env->daif &= ~((imm << 6) & PSTATE_DAIF); + /* This may result in pending IRQs being unmasked so ensure we + exit the loop */ + cpu_exit(ENV_GET_CPU(env));
That works for me. And I guess that takes care of any potential problems with A32 as well?
r~
