Mao Zhongyi <maozy.f...@cn.fujitsu.com> wrote: > From: Cao jin <caoj.f...@cn.fujitsu.com> > > The non-blocking connect mechanism is obsolete, and it doesn't > work well in inet connection, because it will call getaddrinfo > first and getaddrinfo will blocks on DNS lookups. Since commit > e65c67e4 & d984464e, the non-blocking connect of migration goes > through QIOChannel in a different manner(using a thread), and > nobody use this old non-blocking connect anymore. > > Any newly written code which needs a non-blocking connect should > use the QIOChannel code, so we can drop NonBlockingConnectHandler
Reviewed-by: Juan Quintela <quint...@redhat.com> ... > int inet_connect_saddr(InetSocketAddress *saddr, > - NonBlockingConnectHandler *callback, void *opaque, > Error **errp); In case you have to respin it. Now you can write the prototype in a single line, no? Same for the rest of appearances.
