On 22/06/2017 09:06, Zhong Yang wrote: >> On 21/06/2017 12:19, Yang Zhong wrote: >>> Move tcg_handle_interrupt() from translate-common.c to >>> translate-all.c. >>> >>> Signed-off-by: Yang Zhong <[email protected]> >> Why? >> >> Paolo >> > Hello Paolo, > > translate-common.c only include one tcg_handle_interrupt() fucntion, when i > move tcpu_interrupt_handler = tcg_handle_interrupt in tcg_exec_init() for > disable-tcg, > maybe moving the tcg_handle_interrupt() function definition into same file > with tcg_exec_init() > function is better. those are like cpu_interrupt_handler = > kvm_handle_interrupt did in kvm-all.c. thanks!
Looking again at translate-common.c, it makes more sense to merge it with accel/tcg/tcg-all.c. The tcg_handle_interrupt can become static and the cpu_interrupt_handler assignment can go in tcg-all.c's tcg_init function. The declaration for cpu_interrupt_handler can be placed in qom/cpu.c. Paolo
