On Fri, Jun 23, 2017 at 03:46:53PM +0300, Manos Pitsidianakis wrote: > This commit gathers ThrottleGroup membership details from > BlockBackendPublic into ThrottleGroupMember and refactors existing code > to use the structure.
This summarizes the code change but doesn't explain why it's necessary. I suggest something like this: This patch eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. > Signed-off-by: Manos Pitsidianakis <el13...@mail.ntua.gr> > --- > block/block-backend.c | 66 +++++---- > block/qapi.c | 8 +- > block/throttle-groups.c | 304 > ++++++++++++++++++++-------------------- > blockdev.c | 4 +- > include/block/throttle-groups.h | 15 +- > include/qemu/throttle.h | 26 ++++ > include/sysemu/block-backend.h | 20 +-- > tests/test-throttle.c | 53 +++---- > 8 files changed, 260 insertions(+), 236 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature