On 27.06.2017 17:32, David Hildenbrand wrote: > On 27.06.2017 13:48, Thomas Huth wrote: >> To be able to use some more advanced libc functions in the s390-ccw >> firmware, like printf() and malloc(), we need a better libc here. >> This patch adds the C library from the SLOF firmware (taken from >> the SLOF commit ID 62674aabe20612a9786fa03e87cf6916ba97a99a). The >> files are copied without modifications here and will be adapted for >> the s390-ccw firmware by the next patch. I just removed the getopt() >> and scanf()-like functions from the libc since we likely do not need >> them in the s390-ccw firmware. >> > > We have SLOF as a git submodule in roms/SLOF. > > I wonder if there would a way to avoid duplicating files. > > E.g. build s390x-ccw.img only if roms/SLOF is checked out and link/copy > the right folder. > > Then, also the question regarding coding style is gone. > > Would something like that work?
Cool idea, I like it at a first glance. It might be possible ... but that also creates a lot of dependencies, e.g. each time there is a related change in the SLOF repository, you run into the problem that it might affect the s390-ccw firmware, too. Not sure whether we really always want to deal with that situation... Thomas
