Re: [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI

[Manos Pitsidianakis]

On Wed, Jun 28, 2017 at 03:35:48PM +0200, Alberto Garcia wrote:

On Fri 23 Jun 2017 02:46:57 PM CEST, Manos Pitsidianakis wrote:

+# @BlockdevOptionsThrottle:
+#
+# Driver specific block device options for Throttle
+#

I would put this earlier in the json file, together with the rest of the
BlockdevOptions* structs.

+# @throttling-group: the name of the throttling group to use

Why not call it simply "group" ?

Sure! :)

+#
+# @options:        BlockIOThrottle options
+# Since: 2.9
+##
+{ 'struct': 'BlockdevOptionsThrottle',
+  'data': { 'throttling-group': 'str',
+            'file' : 'BlockdevRef',
+            '*options' : 'BlockIOThrottle'
+             } }

Not sure if 'file' is the best name for the field ("child"?), but I'm
fine with it.

There doesn't seem to be a consistent naming scheme in block-core.json ("file", "image" are candidates) so I put it file after bs->file.

signature.asc
Description: PGP signature