On Tue, Jun 27, 2017 at 12:10:19PM +0800, Peter Xu wrote:
> Now we have some globals that can be configured for migration. Dump them
> in HMP info migration for better debugging.
>
> (we can also use this to monitor whether COMPAT fields are applied
> correctly on compatible machines)
>
> Reviewed-by: Juan Quintela <quint...@redhat.com>
> Signed-off-by: Peter Xu <pet...@redhat.com>
[...]
> +void migration_global_dump(Monitor *mon)
> +{
> + MigrationState *ms = migrate_get_current();
> +
> + monitor_printf(mon, "globals: store-global-state=%d, only_migratable=%d,
> "
> + "send-configuration=%d, send-section-footer=%d\n",
> + ms->store_global_state, ms->only_migratable,
> + ms->send_configuration, ms->send_section_footer);
I wouldn't call them "globals", I would just call them "properties" (or
maybe just "settings"). They happen to be affected by global properties
if the accel/machine/user sets them, but they are just plain old QOM
properties.
> +}
> +
> static Property migration_properties[] = {
> DEFINE_PROP_BOOL("store-global-state", MigrationState,
> store_global_state, true),
> --
> 2.7.4
>
--
Eduardo
