On 2017-06-30 21:41, Eric Blake wrote: > On 06/29/2017 09:46 PM, Max Reitz wrote: > >>>> +++ b/tests/qemu-iotests/common.config >>>> @@ -103,6 +103,12 @@ if [ -z "$QEMU_VXHS_PROG" ]; then >>>> export QEMU_VXHS_PROG="`set_prog_path qnio_server`" >>>> fi >>>> >>>> +export QEMU_PROG=$(realpath -- "$(type -p "$QEMU_PROG")") >>> >>> ...now that you updated per my review to favor 'type' over 'which'? >>> Otherwise, the R-b stands. >> >> Thanks, will fix and apply then... >> >> ...and done, applied to my block branch: >> >> https://github.com/XanClic/qemu/commits/block > > Sorry for not noticing sooner, but you'll need to replace v4 (commit > 0f0fec82 on your branch) with a fix, because now your branch does the > following on all iotests for me: > > 068 3s ... - output mismatch (see 068.out.bad) > --- /home/eblake/qemu/tests/qemu-iotests/068.out 2017-06-26 > 22:02:56.057734882 -0500 > +++ 068.out.bad 2017-06-30 14:35:28.720241398 -0500 > @@ -1,4 +1,5 @@ > QA output created by 068 > +realpath: '': No such file or directory
Oops. > The culprit? $QEMU_VXHS_PROG is empty for me, which means `set_prog_path > qnio_server` found nothing to use. You'll have to add in a safety valve > that only calls 'type' if operating on a non-empty path in the first place. Sure, will drop the patches and send a v5. Thanks! Max
signature.asc
Description: OpenPGP digital signature