On Mon, Jul 03, 2017 at 06:34:32PM +0200, Paolo Bonzini wrote: > This will be useful when the functions are called, early in the configure > process, to filter out targets that do not support hardware acceleration. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > configure | 90 > ++++++++++++++++++++++++++++++++++++++------------------------- > 1 file changed, 55 insertions(+), 35 deletions(-) > > diff --git a/configure b/configure > index c571ad1..0f14e79 100755 > --- a/configure > +++ b/configure > @@ -163,6 +163,50 @@ have_backend () { > echo "$trace_backends" | grep "$1" >/dev/null > } > > +glob() { > + eval test -z '"${1#'"$2"'}"' > +} > + > +supported_hax_target() { > + test "$hax" = "yes" || return 1 > + glob "$1" "*-softmmu" || return 1 > + case "${1%-softmmu}" in > + i386|x86_64) > + return 0 > + ;; > + esac > + return 1 > +} > + > +supported_kvm_target() { > + test "$kvm" = "yes" || return 1 > + glob "$1" "*-softmmu" || return 1 > + case "${1%-softmmu}:$cpu" in > + arm:arm | aarch64:aarch64 | \ > + i386:i386 | i386:x86_64 | i386:x32 | \ > + x86_64:i386 | x86_64:x86_64 | x86_64:x32 | \
IIUC, 'x86_64:i386' is claiming that you can run x86_64 KVM guests on an i386 host. I thought that was impossible, only 32-on-64 being allowed not 64-on-32. > + mips:mips | mipsel:mips | \ > + ppc:ppc | ppcemb:ppc | ppc64:ppc | \ > + ppc:ppc64 | ppcemb:ppc64 | ppc64:ppc64 | \ Same question here with ppc64:ppc suggesting you can run 64-bit guest with KVM on a 32-bit host ? > + s390x:s390x) > + return 0 > + ;; > + esac > + return 1 > +} > + > +supported_xen_target() { > + test "$xen" = "yes" || return 1 > + glob "$1" "*-softmmu" || return 1 > + case "${1%-softmmu}:$cpu" in > + arm:arm | aarch64:aarch64 | \ > + i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64) This again is claiming support for 64-bit guests with Xen on a 32-bit host, which AFAIK is impossible. > + return 0 > + ;; > + esac > + return 1 > +} Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|