Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > stream_complete() skips the work of rewriting the backing file if > the job was cancelled, if data->reached_end is false, or if there > was an error detected (non-zero data->ret) during the streaming. > But note that in stream_run(), data->reached_end is only set if the > loop ran to completion, and data->ret is only 0 in two cases: > either the loop ran to completion (possibly by cancellation, but > stream_complete checks for that), or we took an early goto out > because there is no bs->backing. Thus, we can preserve the same > semantics without the use of reached_end, by merely checking for > bs->backing (and logically, if there was no backing file, streaming > is a no-op, so there is no backing file to rewrite). > > Suggested-by: Kevin Wolf <kw...@redhat.com> > Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Kevin Wolf <kw...@redhat.com>
