Luiz Capitulino <lcapitul...@redhat.com> writes:
> On Fri, 12 Nov 2010 11:21:57 +0100
> Markus Armbruster <arm...@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitul...@redhat.com> writes:
[...]
>> > +QString *qemu_chr_mem_to_qs(CharDriverState *chr)
>> > +{
>> > + MemoryDriver *d = chr->opaque;
>> > +
>> > + if (d->outbuf_size == 0) {
>> > + return qstring_new();
>> > + }
>>
>> Why is this necessary? Is qstring_from_substr() broken for empty
>> substrings? If it is, it ought to be fixed!
>
> qstring_from_substr() takes a character range; outbuf_size stores a size,
> not a string length. So we do:
>
>> > + return qstring_from_substr((char *) d->outbuf, 0, d->outbuf_size - 1);
>
> If outbuf_size is 0, we'll be passing a negative value down.
What's wrong with that?
[...]
