Kevin Wolf <kw...@redhat.com> writes: > Am 12.11.2010 17:34, schrieb Stefan Hajnoczi: >> On Fri, Nov 12, 2010 at 3:43 PM, Kevin Wolf <kw...@redhat.com> wrote: >>> Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: >>>> +/** >>>> + * Check whether an image format is raw >>>> + * >>>> + * @fmt: Backing file format, may be NULL >>>> + */ >>>> +static bool qed_fmt_is_raw(const char *fmt) >>>> +{ >>>> + return fmt && strcmp(fmt, "raw") == 0; >>>> +} >>> >>> People shouldn't use them directly, but should we also consider file, >>> host_device, etc.? >> >> Hrm..I will look into it for v5. I thought we always have a "raw" >> format on top of "file", "host_device", etc protocols? > > That's how it's meant to be used. I think at the moment we still allow > to directly use file etc. and you know that if something is possible, > users will do it.
It's possible, it's perfectly well-defined, and it works. > But instead of listing all of them here, maybe we should just make the > final step and return an error if they are used directly. No. > Unfortunately, > that will bring us back to the discussion about formats and protocols... ;-) /me runs away screaming [...]