On Thu, Jul 06, 2017 at 16:26:52 -0400, Emilio G. Cota wrote: > On Tue, Jul 04, 2017 at 13:12:02 +0200, Paolo Bonzini wrote: > > Reviewed-by: Richard Henderson <r...@twiddle.net> > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> (snip) > > +++ b/accel/tcg/translate-all.c > > @@ -1851,6 +1851,11 @@ void dump_exec_info(FILE *f, fprintf_function > > cpu_fprintf) > > > > tb_lock(); > > > > + if (!tcg_enabled()) { > > + cpu_fprintf(f, "TCG not enabled\n"); > > + return; > > + } > > Sorry I missed this before it was merged, but: > > - We're returning with tb_lock held > - This check is redundant; see b7da97eef ("monitor: Check whether TCG > is enabled before running the "info jit" code") which was merged > in April (hmp_info_jit is the only caller of dump_exec_info). > > I suggest we get rid of the check, although moving it above tb_lock is > also OK with me.
Patch here: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02072.html This other patch fixes another issue introduced in this series, please have a look as well: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02058.html Cheers, Emilio