On Tue, Jul 11, 2017 at 09:49:30PM +0100, Peter Maydell wrote: > On 11 July 2017 at 21:26, Mark Cave-Ayland > <mark.cave-ayl...@ilande.co.uk> wrote: > > On 11/07/17 21:18, Michael S. Tsirkin wrote: > > > >> Multi-line comments also should formatted > >> > >> /* > >> * like > >> * this > >> */ > >> > >> not > >> > >> /* like > >> * this */ > >> > > > > Interesting, I never knew there was a preferred format for comments (I > > see both styles throughout the codebase). > > It's basically GNU coding standard style vs Linux kernel style; > there's a mix because some contributors are more used to working > on the kernel, and some more used to working with gcc, glibc, > etc, and we haven't made a firm "comments must be like this" > statement (and of course historical practice in the codebase > is all over the place). > > We also have both of the flavours the kernel style guide > documents: > https://www.kernel.org/doc/html/v4.10/process/coding-style.html#commenting > (I usually use the style the kernel has for net/ personally.) > > So I don't think that "we" the project have a preferred > format; but "we" individual contributors probably > have individual preferences ;-)
Thanks for the info. Please forget when I said I was going to send a CODING_STYLE patch for that. :) -- Eduardo
