* Peter Xu (pet...@redhat.com) wrote: > Export migration parameters to qdev properties. Then we can use, for > example: > > -global migration.cpu-throttle-initial=xxx > > To specify migration parameters during init. > > One thing to mention is that, this usage should only be used for > debugging/testing purpose, and should never be used elsewhere. > Meanwhile, we don't guarantee the compatibility of this interface. It > can alter anytime in the future. > > (Ok, it won't change a lot. But it'll just work like HMP - Let's just be > prepare for any possible change to it) > > Signed-off-by: Peter Xu <pet...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > --- > migration/migration.c | 35 +++++++++++++++++++++++++---------- > 1 file changed, 25 insertions(+), 10 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index a0db40d..fd00670 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2009,6 +2009,31 @@ static Property migration_properties[] = { > send_configuration, true), > DEFINE_PROP_BOOL("send-section-footer", MigrationState, > send_section_footer, true), > + > + /* Migration parameters */ > + DEFINE_PROP_INT64("compress-level", MigrationState, > + parameters.compress_level, > + DEFAULT_MIGRATE_COMPRESS_LEVEL), > + DEFINE_PROP_INT64("compress-threads", MigrationState, > + parameters.compress_threads, > + DEFAULT_MIGRATE_COMPRESS_THREAD_COUNT), > + DEFINE_PROP_INT64("decompress-threads", MigrationState, > + parameters.decompress_threads, > + DEFAULT_MIGRATE_DECOMPRESS_THREAD_COUNT), > + DEFINE_PROP_INT64("cpu-throttle-initial", MigrationState, > + parameters.cpu_throttle_initial, > + DEFAULT_MIGRATE_CPU_THROTTLE_INITIAL), > + DEFINE_PROP_INT64("cpu-throttle-increment", MigrationState, > + parameters.cpu_throttle_increment, > + DEFAULT_MIGRATE_CPU_THROTTLE_INCREMENT), > + DEFINE_PROP_INT64("max-bandwidth", MigrationState, > + parameters.max_bandwidth, MAX_THROTTLE), > + DEFINE_PROP_INT64("downtime-limit", MigrationState, > + parameters.downtime_limit, > + DEFAULT_MIGRATE_SET_DOWNTIME), > + DEFINE_PROP_INT64("x-checkpoint-delay", MigrationState, > + parameters.x_checkpoint_delay, > + DEFAULT_MIGRATE_X_CHECKPOINT_DELAY), > DEFINE_PROP_END_OF_LIST(), > }; > > @@ -2027,16 +2052,6 @@ static void migration_instance_init(Object *obj) > ms->state = MIGRATION_STATUS_NONE; > ms->xbzrle_cache_size = DEFAULT_MIGRATE_CACHE_SIZE; > ms->mbps = -1; > - ms->parameters = (MigrationParameters) { > - .compress_level = DEFAULT_MIGRATE_COMPRESS_LEVEL, > - .compress_threads = DEFAULT_MIGRATE_COMPRESS_THREAD_COUNT, > - .decompress_threads = DEFAULT_MIGRATE_DECOMPRESS_THREAD_COUNT, > - .cpu_throttle_initial = DEFAULT_MIGRATE_CPU_THROTTLE_INITIAL, > - .cpu_throttle_increment = DEFAULT_MIGRATE_CPU_THROTTLE_INCREMENT, > - .max_bandwidth = MAX_THROTTLE, > - .downtime_limit = DEFAULT_MIGRATE_SET_DOWNTIME, > - .x_checkpoint_delay = DEFAULT_MIGRATE_X_CHECKPOINT_DELAY, > - }; > ms->parameters.tls_creds = g_strdup(""); > ms->parameters.tls_hostname = g_strdup(""); > } > -- > 2.7.4 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK