On 15 July 2017 at 03:42, David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Jul 14, 2017 at 04:13:05PM +0100, Peter Maydell wrote: >> Hi. I'm afraid this fails to build on the w32 compiler: >> CC ppc64-softmmu/hw/ppc/spapr.o >> /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c: In function >> ‘spapr_get_resize_hpt’: >> /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:2642:1: error: >> control reaches end of non-void functio >> n [-Werror=return-type] >> } > > Drat. Is there an easy way to test compile for w32?
I have a cross-compiler set up on an Ubuntu host; you can do it on Redhat hosts too; instructions on the wiki somewhere I think. In this case I think you're either getting caught by the age of the compiler or because this set of w32 headers have a bug where assert() doesn't get marked as fatal somehow, so it might or might not manifest on other w32 cross build setups. > Yes, seems good. Should I resend, or will you adjust in place? You'll need to resend -- I can't modify signed pull reqs. thanks -- PMM
