On Wed, 19 Jul 2017 12:25:53 +0800 (CST) <wang.y...@zte.com.cn> wrote:
> >On Mon, 17 Jul 2017 21:49:37 -0400 > > >Yi Wang <address@hidden> wrote: > > > > > >> Add [vcpu] index support for hmp command "info lapic", which is > > >> useful when debugging ipi and so on. Current behavior is not > > >> changed when the parameter isn't specified. > > >we shouldn't expose cpu_index to users anymore, > > > > > >I would suggest using to use real APIC ID here but we don't > > >have monitor command that returns APIC IDs for present cpus. > > > > > Would you like to explain the reason we shouldn't use cpu_index any > > more, which is more straightforward than socket-id/core-id/thread-id? > > As Eduardo wrote in the next reply, "CPU #<n>" is already a perfectly > > good identifier for a human interface :-) We are working on hiding cpu_index from user interface, it's still work in progress but and having old commands, that use cpu_index and haven't been fixed yet, doesn't mean that we should add more. Anyways as Eduardo pointed out combo of cpu/info lapic should be sufficient for your task and this patch seems unnecessary. > > Many thanks. > > > > > > --- > > Best wishes > > Yi Wang
