On 07/20/2017 05:00 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Make it clear that the name parameter to visit_start_struct() >> has the same semantics as for visit_start_int(). >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> ---
>> + * The @name parameter of visit_type_FOO() and visit_start_OBJECT() > > Our terminology is horrible: > > JSON object / QDict / QAPI complex type (struct or union) > JSON array / QList / QAPI array or list (used interchangeably) > JSON value / QObject / QAPI I'm-not-even-sure-what > > Because of this mess, nobody knows what you mean when you say OBJECT. > > visit_start_BAR()? Works for me. > Reviewed-by: Markus Armbruster <arm...@redhat.com> Since you suggested it, I'll keep your R-b when I send v2. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
