Dne 20.7.2017 v 20:42 Eduardo Habkost napsal(a): > On Thu, Jul 20, 2017 at 06:28:14PM +0200, Lukáš Doktor wrote: > [...] >> @@ -83,8 +80,11 @@ class QEMUQtestMachine(qemu.QEMUMachine): >> socket_scm_helper=None): >> if name is None: >> name = "qemu-%d" % os.getpid() >> - super(QEMUQtestMachine, self).__init__(binary, args, name=name, >> test_dir=test_dir, >> - >> socket_scm_helper=socket_scm_helper) >> + scm_helper = socket_scm_helper > > Why is this necessary? > to avoid > 80 chars line. It should be optimized-out by the python compiler so it should not slow down the execution. Alternative solution is to use:
super(QEMUQtestMachine, self.__init__(...) which looks IMO uglier, but I can use that in v2, should that be your preferred style. Lukáš >> + super(QEMUQtestMachine, self).__init__(binary, args, name=name, >> + test_dir=test_dir, >> + socket_scm_helper=scm_helper) >> + self._qtest = None >> self._qtest_path = os.path.join(test_dir, name + "-qtest.sock") >> >> def _base_args(self): >> -- >> 2.9.4 >> >
signature.asc
Description: OpenPGP digital signature