Richard Henderson <r...@twiddle.net> writes: > On 07/20/2017 05:04 AM, Alex Bennée wrote: >> + for (pass = 0; pass < elements; pass++) { >> + TCGv_i32 tcg_op1 = tcg_temp_new_i32(); >> + TCGv_i32 tcg_res = tcg_temp_new_i32(); >> + >> + read_vec_element_i32(s, tcg_op1, rn, pass, MO_16); >> + >> + switch (fpopcode) { >> + default: >> + fprintf(stderr,"%s: insn %#04x fpop %#2x\n", __func__, insn, >> fpopcode); >> + unsupported_encoding(s, insn); >> + } > > Just noticing that we ought not issue N copies of the > unsupported_encoding exception. Return afterwards seems in order. Is > this a pattern that you copied that wants fixing elsewhere?
No that's just me. I think all the other cases just define g_assert_not_reached() as the unsupported encoding should be picked up further up the call chain. I shall fix that. -- Alex Bennée